-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree viewset for retrieving nested, paginated views of topic trees #8138
Tree viewset for retrieving nested, paginated views of topic trees #8138
Conversation
Slightly refactor to handle edge cases and reduce JOINs.
Simplify caching.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple requests for comments in the contentNode.js
otherwise it looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EDIT: - With this branch off of this PR's branch checked out I saw completely solid response times and payloads 👍
I'm also getting 30+ second loading times and every payload coming back is precisely 16.7MB.
I can't even view the response from the server because it freezes the browser tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor details. Overall it looks great
…viewsets. Only used for DRF YASG documentation generation.
8d56499
to
5b2de43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I see it good to go.
Summary
results
Array, andmore
which is eithernull
or an object with the parameters that can be passed to the same endpoint in order to query for more results.References
Fixes #8108
Contributes to the solution for #7525
I did a dummy implementation using the current topics page as a PoC of using this API, an animation is seen here, but I did not commit the changes for this:
Reviewer guidance
Does the API and its tests make sense?
Are the changes to the ContentNodeResource a good model for handling read only resources in the future?
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)