Stop TextTruncator from briefly showing full text before shave.js truncates it #8101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
text
prop before shave.js can work on it. These styles are removed after shave.js has completed its work.updateTitle
calls during thebeforeDestroy
hook so the code isn't executed later when the component is unmounted (creating a lot of logs in the console).Screengrabs from TE - China
Before
After
There is a slight change after shave.js works, but much more subtle than before
References
Fixes #7982
Reviewer guidance
Find a channel where nodes have long descriptions like Touchable Earth or CK-12. You should be able to browse the Lesson Creation workflow without seeing the issues in #7982
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)