You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Problem 1: Shave.js stops truncating text right before navigation
Here, the card will expand after I click it
Problem 2: debounced callback in TextTruncator gets called after it is destroyed, causing errors in the console
Root cause
I think you need to look at the watcher for currentDimensions in TextTruncator.vue. It seems to be calling the handleUpdate callback, at inappropriate times during the component lifecycle. Possibly, it should not do anything when the component is about to be destroyed.
Expected behavior
1.For Problem 1: The card should remain visually the same until it is completely unmounted. It should not briefly flash the untruncated resource description.
2. For Problem 2: The debounced function should not be called when the card is about to be unmounted. Or else, the error is handled or avoided.
Steps to reproduce
Download the QA channel with ID 95a52b386f2c485cb97dd60901674a98
Navigate it in the lesson creation workflow.
Context
0.14.7
The text was updated successfully, but these errors were encountered:
Observed behavior
Problem 1: Shave.js stops truncating text right before navigation
Here, the card will expand after I click it
Problem 2: debounced callback in
TextTruncator
gets called after it is destroyed, causing errors in the consoleRoot cause
I think you need to look at the watcher for
currentDimensions
inTextTruncator.vue
. It seems to be calling thehandleUpdate
callback, at inappropriate times during the component lifecycle. Possibly, it should not do anything when the component is about to be destroyed.Expected behavior
1.For Problem 1: The card should remain visually the same until it is completely unmounted. It should not briefly flash the untruncated resource description.
2. For Problem 2: The debounced function should not be called when the card is about to be unmounted. Or else, the error is handled or avoided.
Steps to reproduce
95a52b386f2c485cb97dd60901674a98
Context
0.14.7
The text was updated successfully, but these errors were encountered: