In Facility task cards, only quote the facility name and not the ID fragment

[jonboiser]

Summary

Fixes #7123

References

Reviewer guidance

The tests should confirm the new behavior, but this can be manually confirmed by importing/syncing/deleting a facility in the app.

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[indirectlylit]

I think this PR may have taken away some single-quotes that were actually correct (cc @jonboiser @rtibbles)

[indirectlylit]

This change and similar ones looks incorrect to me. From the design system:

Always wrap user-generated text in 'single quotes'.

[jonboiser]

facilityName is interpolated to something like 'My facility' (a1b2), so the full message should match what you're saying. Check out the tests.

[indirectlylit]

Ah, interesting – I didn't realize that facilityNameWithId was used inside other strings. I think that this pattern, while DRY, is technically incorrect for i18n strings because we're essentially using string concatenation to join two incomplete phrases.

A more technically correct string would include both inputs:

     message: `Sync '{facilityName}' ({id})`, 

My understanding is that this less-DRY format is easier for the translators to work with effectively.

(cc @radinamatic in case you have guidance and @jredrejo from the original change)

None of this is super critical – just wanted to flag for discussion and future work.