Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

name of facility is incorrectly wrapped in single-quotes #7123

Closed
indirectlylit opened this issue Jun 22, 2020 · 0 comments · Fixed by #8093
Closed

name of facility is incorrectly wrapped in single-quotes #7123

indirectlylit opened this issue Jun 22, 2020 · 0 comments · Fixed by #8093
Assignees
@jonboiser
Labels
APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) P2 - normal Priority: Nice to have TAG: user strings Application text that gets translated
Milestone
0.15.0

Comments

@indirectlylit
Copy link
Contributor

Observed behavior

We use single-quotes to wrap user-generated text, like the name of facilities. We use parentheses to wrap the computer-generated IDs of facilities.

The task manager combines the two as Sync '{facility} (id)'

image

Expected behavior

String should be Sync '{facility}' (id)

User-facing consequences

potential confusion about what the actual name of the facility is

Steps to reproduce

import a facility

Context

0.14 beta 3
@indirectlylit indirectlylit added DEV: frontend P2 - normal Priority: Nice to have TAG: user strings Application text that gets translated labels Jun 22, 2020
@indirectlylit indirectlylit added this to the 0.15.0 milestone Jun 22, 2020
@jonboiser jonboiser assigned jonboiser and unassigned jonboiser Jun 22, 2020
@jonboiser jonboiser added the APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) label Feb 20, 2021
@jonboiser jonboiser self-assigned this May 11, 2021
jonboiser added a commit to jonboiser/kolibri that referenced this issue May 19, 2021
@jonboiser
Move facility ID out of quoted phrase
a9292fc 
Fixes learningequality#7123
@jonboiser jonboiser mentioned this issue May 19, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonboiser jonboiser

Labels
APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) P2 - normal Priority: Nice to have TAG: user strings Application text that gets translated
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

In Facility task cards, only quote the facility name and not the ID fragment jonboiser/kolibri
2 participants
@indirectlylit @jonboiser