Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In password-update sign-in flow, block user if password and its confirmation do not match #7814

Merged

Conversation

jonboiser
Copy link
Contributor

@jonboiser jonboiser commented Feb 25, 2021

Summary

Fixes #7810

Here's a gif of the password validation at work, which is similar to the user creation workflow:

CleanShot 2021-02-24 at 17 17 16

Reviewer guidance

This needs to be set up as described in #7810. Basically

  1. When facility settings do not require passwords, create a learner as an admin
  2. Change facility settings to require passwords
  3. Try to login as the learner from step 1

Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@jonboiser jonboiser added changelog Important user-facing changes APP: User Re: User app (sign-in, sign-up, user profile, etc.) labels Feb 25, 2021
@jonboiser jonboiser added this to the 0.14.7 milestone Feb 25, 2021
@jonboiser
Copy link
Contributor Author

jonboiser commented Feb 25, 2021

@metodimilevqa This should fix #7810

@metodimilevqa
Copy link

I confirm the fix of #7810 is successful.

@jonboiser jonboiser merged commit 5d38bb5 into learningequality:release-v0.14.x Feb 26, 2021
@jonboiser jonboiser deleted the fix-pw-confirmation branch February 26, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: User Re: User app (sign-in, sign-up, user profile, etc.) changelog Important user-facing changes
Projects
None yet
2 participants