Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Under specific scenario the "Passwords do not match" assertion is not working and learner user is still able to login #7810

Closed
metodimilevqa opened this issue Feb 23, 2021 · 3 comments · Fixed by #7814
Assignees
Labels
APP: User Re: User app (sign-in, sign-up, user profile, etc.) bug Behavior is wrong or broken P0 - critical Priority: Release blocker or regression
Milestone

Comments

@metodimilevqa
Copy link

Observed behavior

If a learner user is created in superadmin profile while the "Require password for learners" is unchecked in Facility > Settings, and after the learner creation is finished and the "Require password for learners" is checked, then this learner user is prompted for password in the first ever login and is able to login with different input in Password and Confirm password field. The input in Password field is recorded as a valid password and the Confirm password input seems to be ignored. The error message for "Passwords do not match" is displayed for a while before the learner is logged in.

Video-2021-02-23-124539

Expected behavior

"Passwords do not match" assertion is preventing the user to login unless the passwords match.

Steps to reproduce

Preconditions: "Require password for learners" is unchecked in Facility > Settings

  1. Login as a superadmin user
  2. Click the hamburger menu
  3. Click Facility
  4. Click the Users tab
  5. Click New user and fill the form to create a learner account
  6. Go to Facility > Settings tab
  7. Check the "Require password for learners" and click Save
  8. Logout and login as the new learner account
  9. On the Passwords screen fill 2 different inputs in Password and Confirm password fields
  10. Click Login

Context

Kolibri 0.14.7a2
Windows 10
Chrome

@jonboiser jonboiser added the bug Behavior is wrong or broken label Feb 23, 2021
@jonboiser jonboiser added this to the 0.14.7 milestone Feb 23, 2021
@jonboiser jonboiser added the P0 - critical Priority: Release blocker or regression label Feb 23, 2021
@jonboiser jonboiser self-assigned this Feb 24, 2021
@jonboiser
Copy link
Contributor

@metodimilevqa This is a good catch. Does this scenario have a gherkin story?

@metodimilevqa
Copy link
Author

@metodimilevqa This is a good catch. Does this scenario have a gherkin story?

Well, as there are many scenarios, I can't tell for sure but I can do a check

@metodimilevqa
Copy link
Author

@jonboiser I conform the fix is successful with #7814, the issue is no longer experienced

@jonboiser jonboiser added the APP: User Re: User app (sign-in, sign-up, user profile, etc.) label Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: User Re: User app (sign-in, sign-up, user profile, etc.) bug Behavior is wrong or broken P0 - critical Priority: Release blocker or regression
Projects
None yet
2 participants