Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close video.js menu on click away #6371

Merged

Conversation

bjester
Copy link
Member

@bjester bjester commented Dec 17, 2019

Summary

  • The menus listen for any click events that occur outside of their bounds, and close themselves when that occurs
  • The menus toggle closed when their main button is clicked and the menu is currently open

media-player-menus

Reviewer guidance

Ensure this change does not interfere with captioning controls.

References

#6036


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester bjester added the TODO: needs review Waiting for review label Dec 17, 2019
@bjester bjester added this to the 0.13.0 milestone Dec 17, 2019
@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #6371 into release-v0.13.x will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
kolibri/core/content/utils/check_schema_db.py 91.3% <0%> (-8.7%) ⬇️

Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@nucleogenesis nucleogenesis merged commit cc1c6b1 into learningequality:release-v0.13.x Dec 18, 2019
@bjester bjester deleted the media-player-menu-fix branch July 15, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants