Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple video control menus can overlap without clear distinction #6036

Closed
bjester opened this issue Nov 8, 2019 · 2 comments
Closed

Multiple video control menus can overlap without clear distinction #6036

bjester opened this issue Nov 8, 2019 · 2 comments
Assignees
Labels
P1 - important Priority: High impact on UX TAG: ux update Improved user-facing feature
Milestone

Comments

@bjester
Copy link
Member

bjester commented Nov 8, 2019

Observed behavior

The default behavior of control button menus in Video.js allows for overlap of multiple menus. Since adding two new buttons and menus with the transcript feature, all side by side, the overlap of menus can be confusing. The menus can be activated by hover and click, with click bringing up the primary issue.
screenshot-35 197 126 33-8080-2019 11 07-15-51-20
*Red outline for emphasis

Proposed behavior

When activated by click, I propose disabling the hover functionality of the other menus until clicked off, either to another menu or away from the video.

User-facing consequences

Along with #6035 it can be difficult to understand which menu is currently activated and visible so it can cause confusion.

Steps to reproduce

  1. Open a video
  2. Click CC control button
  3. Click Languages control button
  4. Hover over Speed control button
  5. Observe three menus visible at once

Context

Kolibri 0.13 #5631
Occurs in any browser

@bjester bjester added DEV: frontend bug Behavior is wrong or broken TAG: ux update Improved user-facing feature and removed bug Behavior is wrong or broken labels Nov 8, 2019
@indirectlylit
Copy link
Contributor

When activated by click, I propose disabling the hover functionality of the other menus until clicked off, either to another menu or away from the video.

Yes. Alternatively, this might be another argument for your strategy of disabling the 'hover-to-show' function altogether, and only using clicks to hide/show

@indirectlylit indirectlylit added the P2 - normal Priority: Nice to have label Dec 16, 2019
@indirectlylit indirectlylit added this to the 0.13.0 milestone Dec 16, 2019
@indirectlylit indirectlylit added P1 - important Priority: High impact on UX and removed P2 - normal Priority: Nice to have labels Dec 16, 2019
@bjester bjester self-assigned this Dec 16, 2019
@indirectlylit
Copy link
Contributor

indirectlylit commented Dec 17, 2019

decision made with @bjester:

Treat these menus like other pop-up menus, and only allow one open at a time.

  • The menus should listen for any click events that occur outside of their bounds, and close themselves when that occurs
  • The menus should toggle closed when their main button is clicked and the menu is currently open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 - important Priority: High impact on UX TAG: ux update Improved user-facing feature
Projects
None yet
Development

No branches or pull requests

2 participants