-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore iOS support #4671
Restore iOS support #4671
Conversation
Dang, I have no iOS device to test this, will have to add it to my shopping list soon... 😕 |
If you have a Mac and XCode, you can start Kolibri on your Mac and then use the iOS Simulator to start a virtual iOS device and run Safari. That is how I was testing because I didn't have any devices running iOS 9, which is where the bug was triggering. |
Ah, good suggestion @kollivier, didn't think of that route... |
Codecov Report
@@ Coverage Diff @@
## develop #4671 +/- ##
========================================
Coverage 51.42% 51.42%
========================================
Files 833 833
Lines 25088 25088
Branches 3303 3303
========================================
Hits 12901 12901
Misses 11498 11498
Partials 689 689
Continue to review full report at Codecov.
|
Code looks good to me, so I'll leave it to testing to discern this PR's worth! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks - merging in so we can start testing
@kollivier would you mind updating the browserslist
file re: #4672
...as iOS blockers are either resolved or no longer reproduce.
Summary
This change restores Mobile Safari as a supported platform, as #1049 was addressed and the other two blockers don't reproduce (#1046 and #2158).
Contributor Checklist
PR process:
Testing:
Reviewer Checklist
yarn
andpip
)