Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break words on cards #4439

Merged
merged 2 commits into from
Oct 16, 2018
Merged

Break words on cards #4439

merged 2 commits into from
Oct 16, 2018

Conversation

christianmemije
Copy link
Contributor

@christianmemije christianmemije commented Oct 16, 2018

Summary

Before

localhost_8000_learn_

After

localhost_8000_learn_ 1

Reviewer guidance

References

#4419


Contributor Checklist

  • Contributor has fully tested the PR manually
  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If there are any front-end changes, before/after screenshots are included
  • If this is an important user-facing change, PR or related issue has a 'changelog' label

Reviewer Checklist

  • Automated test coverage is satisfactory
  • Reviewer has fully tested the PR manually
  • PR has been tested for accessibility regressions
  • External dependencies files were updated (yarn and pip)
  • Documentation is updated
  • Link to diff of internal dependency change is included
  • CHANGELOG.rst is updated for high-level changes
  • Contributor is in AUTHORS.rst

@christianmemije christianmemije added the TODO: needs review Waiting for review label Oct 16, 2018
@christianmemije christianmemije added this to the 0.11.0 milestone Oct 16, 2018
@benjaoming
Copy link
Contributor

@codecov
Copy link

codecov bot commented Oct 16, 2018

Codecov Report

Merging #4439 into release-v0.11.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           release-v0.11.x    #4439   +/-   ##
================================================
  Coverage            52.52%   52.52%           
================================================
  Files                  720      720           
  Lines                23435    23435           
  Branches              3207     3207           
================================================
  Hits                 12309    12309           
  Misses               10380    10380           
  Partials               746      746
Impacted Files Coverage Δ
...ugins/learn/assets/src/views/ContentCard/index.vue 33.33% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4a2656...e1e2ae4. Read the comment docs.

Copy link
Contributor

@jonboiser jonboiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks gooooooooooooo
ooooooooo
oooooooooood!

@christianmemije
Copy link
Contributor Author

@benjaoming Great catch! Added a fallback
ie

@benjaoming
Copy link
Contributor

Thanks @christianmemije :)

@benjaoming
Copy link
Contributor

Btw. if you're feeling "at it", there are these related issues/PRs :)

#3278
#3723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants