-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long words in title problematic in content cards #4419
Comments
I'm not reproducing in either Learner or Coach |
Overflowing text fixed in #4439 |
As indicated here, the previous solution caused real words to break at arbitrary points. One strategy might be to have the @rtibbles do you see the font movement again after #5479 was merged? |
If anyone else has time to confirm this is still fixed, I would appreciate it. |
Yes, this is the expected behavior at present. In #4439 we tried to address it by breaking at arbitrary points in words, but that led to #5468 which was much more common than this issue, which requires somewhat contrived examples to reproduce. The main thing I want to make sure of for 0.12.4 is that we don't have this behavior:
and it sounds like we don't. Adding the 'needs design' label to hash out possible solutions, e.g. the one described above (cc @khangmach) |
Aaactually I'm confused because in your screenshot, it's still breaking across words! This seems to indicate that #5468 was not fixed. |
I'm not understanding what this means. Do you mean fonts being loaded which change the length of the title?
Without re-designing the entire content card component, having a tooltip sounds like the only reasonable behavior. This comment kind of implies that the user cannot discern what a certain word is without the entire word/string showing. For example, if the word "subtraction" is cut off to "subtrac...", you can reasonably predict what the word is going to be and mentally form the title. For incredibly long nonsense strings/non-western translated words we do need the tooltip shortcut. My thoughts:
Instead of eliminating tooltips and reinventing the wheel here, we should be encouraging better naming practice and be able to have a consistent shortcut behavior in the Kolibri app to help users discern incredibly long words. |
There are two scenarios:
Unfortunately I don't know of any straightforward way of adding an ellipsis for this scenario. The gradient was the only thing I could think of but it would be helpful to get some design input |
closing in favor of #5468 |
Observed behavior
@christianmemije reports:
Long card title get cut off inside cards, fonts popping in making text shift
Expected behavior
Titles always get displayed in a length sensitive way.
Fonts should not pop in and make text move!
User-facing consequences
Can't read titles.
Jerky visual experience.
Steps to reproduce
Look at a content card with a long title.
Context
The text was updated successfully, but these errors were encountered: