Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI and add additional info to Learner Reports pages #12711

Merged

Conversation

LianaHarris360
Copy link
Member

Summary

This pull request updates the UI for the the Reports pages at reports/ReportsLearnerReportPage.vue and reports/ReportsLearnerListPage.vue.

  • Adds header slot to ReportsHeader.vue and class title + placeholder KSelect filter to reports/ReportsLearnerListPage.vue
  • Changes the main header in reports/ReportsLearnerReportPage.vue to align with the design specifications in Figma, ensuring it has a more dashboard-like appearance, uses a basic grid that stacks the header elements for mobile responsiveness.
  • Implements + integrates a "Lessons Completed" section into the user interface, including the necessary calculations.
  • Seperates the header within the ReportsLearnerActivityPage and ReportsLearnerReportPage, without makign changes to the "Lessons Assigned / Quizzes Assigned" sections.

Updated ReportsLearnerListPage:
ReportsLearnerListPage

Updated ReportsLearnerActivityPage:
ReportsLearnerActivityPage

Updated ReportsLearnerReportPage:
ReportsLearnerReportPage

References

Closes #12679

Reviewer guidance

  1. Create a class and lesson and assign learner(s)
  2. Navigate to the Reports > Learners tab and ensure the UI changes match the (Figma specs)
  3. Select a learner to open the ReportsLearnerReportPage and ensure the new header elements are responsive + the calculations for "lessons completed" are correct.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Oct 8, 2024
@MisRob MisRob removed their request for review October 10, 2024 17:06
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, Liana! This looks great

@LianaHarris360 LianaHarris360 merged commit e1514b0 into learningequality:develop Oct 17, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Learner Reports pages to have additional information and updated UI
2 participants