Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Activity" tab from learner view #12733

Closed
12 tasks done
Tracked by #11888
marcellamaki opened this issue Oct 22, 2024 · 3 comments · Fixed by #12816
Closed
12 tasks done
Tracked by #11888

Remove "Activity" tab from learner view #12733

marcellamaki opened this issue Oct 22, 2024 · 3 comments · Fixed by #12816
Assignees
Labels
DEV: frontend P1 - important Priority: High impact on UX

Comments

@marcellamaki
Copy link
Member

marcellamaki commented Oct 22, 2024

Overview

As part of the information architecture refactor, we need to do a little bit more follow up on the new learner overview/report page - ReportsLearnerReportPage.

Please review #12679 and #12711 for context of the past changes.

Current state of develop:
Image

Figma:
Image
Image

In addition to the code cleanup, add "pagination".

  • For both Lessons and quizzes display the first 10 items of the array
  • If there are >10 Items, display a view more button
  • On click, render another 10 items
  • If still more items, on click, view the rest, no matter how many)
  • If there are no more items to be shown (the user is viewing all), hide the "view more" button

Acceptance Criteria

Code cleanup:

  • Remove the use of Tabs and clean up related code
  • Remove the rendering of the ActivityList on this page (do not delete the file, it's in kolibri-common)
    Layout/styling:
  • Retain the use of grids so the containers stack properly on mobile
  • Ensure everything matches the figma in terms of spacing and layout (using the dev mode if needed)
  • Everything looks okay on tablet and mobile
    New features:
  • Pagination is implemented according to the spec
    What else?
  • No regressions
@apoorvapendse
Copy link

apoorvapendse commented Oct 30, 2024

Image
Do you mean this one? @marcellamaki

@marcellamaki
Copy link
Member Author

Hi @apoorvapendse - nope, this issue actually isn't about that. This issue is not ready for assignment, as you can see it hasn't been written yet and there are no details or tags on the issue.

If you're interested in contributing to Learning Equality projects, please look at the Kolibri contribution guidelines to get a better sense of our open source process. Choosing from "help wanted" or "good first issue" would be the best place for you to find ways to contribute and engage with the team.

@apoorvapendse
Copy link

Thanks @marcellamaki, will look into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend P1 - important Priority: High impact on UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants