-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC] Use KTable in Facility -> Classes #12571
Conversation
Build Artifacts
|
This is looking great @BabyElias !!! 👏🏽
One possible improvement would be in the area of how we notify that the columns are sortable, and after they have been sorted. Let's discuss if we could take some inspiration from examples here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The KTable looks great, I'm so excited to see it used in Kolibri! I only had a few notes to make.
kolibri/plugins/facility/assets/src/views/ManageClassPage/index.vue
Outdated
Show resolved
Hide resolved
kolibri/plugins/facility/assets/src/views/ManageClassPage/index.vue
Outdated
Show resolved
Hide resolved
@radinamatic mentioned to me that she re-tested and it all worked smooth so in her absence, I am leaving this note as QA approval :) Regarding the improvements suggested in https://dequeuniversity.com/library/aria/table-sortable, Radina is going to clarify the requirements at some point and then we will open a follow-up issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BabyElias Code-wise, all seems to be ready to me too. We just need to pull in the latest KDS release with the KTable
as soon as it's released.
We can do final QA here, but the KDS upgrade as a whole will be handled in #12651 (the test failures should be resolved by that as well as some other breaking changes) |
Kolibri already has the release with changes needed in this PR. I can rebase and get it ready for merge. |
I did one last quick preview of the latest pex and all looks good! Wonderful work. |
Summary
This PR introduces
KTable
component to Kolibri as a part of GSoC Project : Accessible Sortable Table.The component is still under review in KDS.
Reviewer guidance
New Class
buttonNew Class
button to check functionalities of the table component.QA Testing Guidance
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)