Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore preseeded database behaviour #12494

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

rtibbles
Copy link
Member

Summary

  • Our sqlite foreign key integrity checks didn't first check if the database file existed
  • So when the connection was opened, the file was created
  • This was preventing the preseeded database setup from happening

References

Helps to fix #227

Reviewer guidance

Ensure when running kolibri in a fresh env, that database migrations don't happen, and instead it goes straight to setup.

Should also reduce loading times considerably for the Android app.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added the DEV: backend Python, databases, networking, filesystem... label Jul 27, 2024
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not run any migrations when running the WHL file from the PR, in virtualenv with a new KOLIBRI_HOME

@rtibbles rtibbles merged commit 41982e6 into learningequality:release-v0.17.x Jul 29, 2024
33 checks passed
@rtibbles rtibbles deleted the restore_preseed branch July 29, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants