fixes user selection getting lost on closing the sidepanel

[AllanOXDi]

Summary

Fixes user selection getting lost on closing the sidepanel
Closes #12135

References

#12135

Reviewer guidance

1. Navigate to the select questions
2. Check the question you want to replace
3. Click replace icon
4. Close the side panel

…

---

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-.pex
Windows Installer (EXE)	kolibri-0.16.2b1.dev0+git.1093.g78cdccd1-windows-setup-unsigned.exe
Debian Package	kolibri_0.16.2b1.dev0+git.1093.g78cdccd1-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.2b1.dev0+git.1093.g78cdccd1-0.4.1.dmg
Android Package (APK)	kolibri-0.16.2b1.dev0+git.1093.g78cdccd1-0.1.2-debug.apk
TAR file	kolibri-0.16.2b1.dev0+git.1093.g78cdccd1.tar.gz
WHL file	kolibri-0.16.2b1.dev0+git.1093.g78cdccd1-py2.py3-none-any.whl

[AlexVelezLl]

LGTM, code change makes sense and I tried some use cases and the bug has been fixed.

But the fact that there was a call to clearSelectedQuestions when closing the side Panel made me question if perhaps the intention was to clear the replacements.

Because these are not cleared anywhere, and if you do multiple replacements in a row, the references from the previous replacements continue. So probably instead of a clearSelectedQuestions there should be a clearReplacements on the beforeRouterLeave @nucleogenesis?

Compartir.pantalla.-.2024-05-12.19_04_51.mp4

[nucleogenesis]

The original page's selection is updated but replacements is not being cleared. I think that you could set the value of replacements in handleConfirmClose where we handle when the user says "Continue" to the alert telling them they'll lose their changes.

2024-05-14.14-11-20.mp4

[nucleogenesis]

The updates here LGTM after some testing! Thanks Allan

[AlexVelezLl]

Hi @AllanOXDi The error still happens when we save the questions. Because we are only clearing the replacements when we exit without saving the questions:

Compartir.pantalla.-.2024-05-20.23_51_20.mp4

My suggestion would be to clean the replacements on this line, on router leave. So it would work for both cases.

[AlexVelezLl]

Thanks @AllanOXDi! LGTM 🎉