Merge pull request #12160 from AllanOXDi/fix_user_selection_getting_lost

fixes user selection getting lost on closing the sidepanel
learningequality · May 21, 2024 · 28b1ba3 · 28b1ba3
2 parents c47d734 + a97c588
commit 28b1ba3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/kolibri/plugins/coach/assets/src/composables/useQuizCreation.js b/kolibri/plugins/coach/assets/src/composables/useQuizCreation.js
@@ -174,6 +174,7 @@ export default function useQuizCreation() {
       section_id: activeSection.value.section_id,
       questions: [...questionsNotSelectedToBeReplaced, ...replacements.value],
     });
+    set(replacements, []);
   }
 
   /**

diff --git a/kolibri/plugins/coach/assets/src/views/plan/CreateExamPage/ReplaceQuestions.vue b/kolibri/plugins/coach/assets/src/views/plan/CreateExamPage/ReplaceQuestions.vue
@@ -204,11 +204,13 @@
       const showReplacementConfirmation = ref(false);
 
       function handleConfirmClose() {
+        replacements.value = [];
         context.emit('closePanel');
       }
 
       function submitReplacement() {
         handleReplacement();
+        this.clearSelectedQuestions();
         const count = replacements.value.length;
         router.replace({
           name: PageNames.EXAM_CREATION_ROOT,
@@ -333,7 +335,6 @@
         this.showCloseConfirmation = true;
         next(false);
       } else {
-        this.clearSelectedQuestions();
         next();
       }
     },
-Original file line number
+Diff line change
@@ Expand Up / @@ -174,6 +174,7 @@ export default function useQuizCreation() { @@
           section_id: activeSection.value.section_id,
           questions: [...questionsNotSelectedToBeReplaced, ...replacements.value],
         });
+        set(replacements, []);
       }
       /**
@@ Expand Down @@