Move handleReplacement logic from ReplaceQuestions.vue to useQuizCreation.js

[KshitijThareja]

Summary

This PR aims to move the handleReplacements logic from the file ReplaceQuestions.vue to useQuizCreation.js as it was identified as a tech-debt and is better placed in useQuizCreation. The changes are introduced keeping in mind the requirements of the issue and the discussion in PR #11937.

References

Closes #12012

Reviewer guidance

To verify the working of the changes introduced:

1. Login as an admin/coach.
2. Create a new quiz.
3. After importing the questions, try to replace them using the replace option.

---

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-.pex
Windows Installer (EXE)	kolibri-0.16.1.dev0+git.20240422105756-unsigned.exe
Debian Package	kolibri_0.16.1.dev0+git.20240422105756-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.1.dev0+git.20240422105756-0.4.0.dmg
Android Package (APK)	kolibri-0.16.1.dev0+git.20240422105756-0.1.0-debug.apk
TAR file	kolibri-0.16.1.dev0+git.20240422105756.tar.gz
WHL file	kolibri-0.16.1.dev0+git.20240422105756-py2.py3-none-any.whl

[nucleogenesis]

Thank you @KshitijThareja - I have one blocking and relatively minor question. I'll spin this up later on for a test locally as well

[nucleogenesis]

Is there any particular reason to call this from within a function rather than returning handleReplacement from the setup function?

[KshitijThareja]

I believe we needed the router logic to be placed inside the ReplaceQuestions file itself. Returning handleReplacement from the setup function and directly calling it from @submit handler would require the routing logic to be placed in the handleReplacement function that is now moved to useQuizCreation.
That was the main reason for me to call it from within a function as that provides separation of concerns.

Though I'd like to know if I'm missing something here and if there's a better workaround for this.

[nucleogenesis]

Ahh thanks for that - I misread the diff 😅 - I thought the only thing happening in submitReplacement was calling handleReplacement.

[KshitijThareja]

Oh 😅. No problem :)

[nucleogenesis]

Thanks for this!

[nucleogenesis]

Ahh thanks for that - I misread the diff 😅 - I thought the only thing happening in submitReplacement was calling handleReplacement.