Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiz Creation: Move handleReplacements logic from ReplaceQuestions to useQuizCreation #12012

Closed
1 task
nucleogenesis opened this issue Mar 21, 2024 · 7 comments · Fixed by #12099
Closed
1 task
Assignees
Labels
help wanted Open source contributors welcome

Comments

@nucleogenesis
Copy link
Member

Overview

This is some tech debt we identified during reviews. Basically, the ReplaceQuestions#handleReplacements method doesn't need to live there and is better placed in useQuizCreation -- this will clean-up ReplaceQuestions a bit and house the logic where it belongs.

Acceptance criteria

  • Move handleReplacements logic from ReplaceQuestions to useQuizCreation and clean up after yourself
@nucleogenesis nucleogenesis added the help wanted Open source contributors welcome label Mar 21, 2024
@rd-sharma7
Copy link

rd-sharma7 commented Mar 22, 2024

@nucleogenesis
I am open to work on it. May I go ahead ?

@MisRob
Copy link
Member

MisRob commented Mar 23, 2024

Thank you for volunteering @rd-sharma7, I will assign you

@rd-sharma7
Copy link

@nucleogenesis , @MisRob , I have start working on this , and simultaneously setting up the kolibri environment in my W11 machine . I have done the steps till Development server & get stucked in cmd yarn run devserver ,shows this :

(running in win-Administrator)

Screenshot 2024-03-23 192327

my yarn pkg is on path C:\Program Files (x86)\Yarn

@nucleogenesis I checked out the DB , found that there are three files seems to assoicated with this issue .if you don't mind , can you illustrate the issue little bit more!

@nucleogenesis
Copy link
Member Author

I'm sorry @rd-sharma7 I think that you'll need to wait just a day or two to start on this as it is depending on #11937 being merged (which I'm working on to start this week).

ReplaceQuestions.vue is expanded significantly in that PR and this issue is meant to be a follow-up to that so I was too eager last week in setting this as ready to be worked on.

In any case, those files are correct. Overall, the useQuizCreation module is used for managing UI and overall state for the quiz creation tool in Kolibri. I initially wrote that replaceQuestions method in the ReplaceQuestions component but in review it was suggested that it'd be better suited in the useQuizCreation module.

You can see the soon-to-be-merged version of the ReplaceQuestions.vue file in #11937 which may make the goal of this issue more clear.

If you'll be able to start on this later this week, then I will ping you here again when it is ready.


re: your dev environment & running Kolibri's devserver

I'm not familiar with development on a Windows machine so there may be some issues w/ the configuration there -- however, you'll need to be sure that the directory at C:\Users\ASUS\kolibriSSH is where you cloned the Kolibri Github repo. If you run dir in that directory, what files are listed?

When you run yarn run devserver you'll need to be in the directory where the Kolibri repo lives, so when you dir you should see a package.json and folders like kolibri and requirements and so forth.

@rd-sharma7
Copy link

rd-sharma7 commented Apr 2, 2024

@nucleogenesis thankyou for your kind response , I am feeling disappointing that the issue seems me more critical now ,as it wasn't before , and I start feeling like that i am not able solve this at now .I will looks further to solve others when I get command on languages.
thankyou (-_-)

@KshitijThareja
Copy link
Contributor

Hi @nucleogenesis @MisRob :)
I'd like to work on this issue once the mentioned PR is merged. Feel free to assign it to me.

@MisRob
Copy link
Member

MisRob commented Apr 5, 2024

Alright @KshitijThareja, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open source contributors welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants