-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quiz Creation: Move handleReplacements
logic from ReplaceQuestions
to useQuizCreation
#12012
Comments
@nucleogenesis |
Thank you for volunteering @rd-sharma7, I will assign you |
@nucleogenesis , @MisRob , I have start working on this , and simultaneously setting up the kolibri environment in my W11 machine . I have done the steps till Development server & get stucked in cmd yarn run devserver ,shows this : (running in win-Administrator) my yarn pkg is on path C:\Program Files (x86)\Yarn @nucleogenesis I checked out the DB , found that there are three files seems to assoicated with this issue .if you don't mind , can you illustrate the issue little bit more! |
I'm sorry @rd-sharma7 I think that you'll need to wait just a day or two to start on this as it is depending on #11937 being merged (which I'm working on to start this week).
In any case, those files are correct. Overall, the You can see the soon-to-be-merged version of the If you'll be able to start on this later this week, then I will ping you here again when it is ready. re: your dev environment & running Kolibri's devserver I'm not familiar with development on a Windows machine so there may be some issues w/ the configuration there -- however, you'll need to be sure that the directory at When you run |
@nucleogenesis thankyou for your kind response , I am feeling disappointing that the issue seems me more critical now ,as it wasn't before , and I start feeling like that i am not able solve this at now .I will looks further to solve others when I get command on languages. |
Hi @nucleogenesis @MisRob :) |
Alright @KshitijThareja, thank you |
Overview
This is some tech debt we identified during reviews. Basically, the
ReplaceQuestions#handleReplacements
method doesn't need to live there and is better placed inuseQuizCreation
-- this will clean-upReplaceQuestions
a bit and house the logic where it belongs.Acceptance criteria
handleReplacements
logic fromReplaceQuestions
touseQuizCreation
and clean up after yourselfThe text was updated successfully, but these errors were encountered: