Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useUser can now get all states and getters #12027

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

Wck-iipi
Copy link
Contributor

Summary

useUser can be used to get getters and state of sessions

References

Fixes #11723

Reviewer guidance

I have tested that all these works by console logging them in learn plugin. I have used the computed property because when I tried to use store.state.core.session.state_specified_in_sessionjs, it would not give the right states and would give undefined for some states.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@nucleogenesis nucleogenesis requested a review from rtibbles March 28, 2024 20:50
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, cross-checked and everything is there. Thank you!

@rtibbles rtibbles merged commit bd2ccf8 into learningequality:develop Mar 29, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create equivalent of getters for all accessed session state and all getters in useUser composable
2 participants