Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create equivalent of getters for all accessed session state and all getters in useUser composable #11723

Closed
Tracked by #11722 ...
rtibbles opened this issue Jan 12, 2024 · 7 comments · Fixed by #12027
Closed
Tracked by #11722 ...
Assignees
Labels
DEV: frontend help wanted Open source contributors welcome

Comments

@rtibbles
Copy link
Member

rtibbles commented Jan 12, 2024

We currently have multiple getters and even some state in the session.js Vuex module that is accessed throughout Kolibri.

We have started migrating these references to instead use the useUser core composable, but the composable still does not expose all the needed getters and state that are referenced across Kolibri.

To remedy this, all the getters that are defined in the session.js module should be exposed through the useUser composable in a similar way to those that have already been wrapped.

In addition, all state in the session module should be exposed for consumption via the composable as well.

@dhruvpal05
Copy link

Hey @rtibbles, I can work on this issue, please assign me this issue

@rtibbles
Copy link
Member Author

Sure thing!

@dhruvpal05
Copy link

Hey @rtibbles, just created a PR for this #11738 , do review

@rtibbles
Copy link
Member Author

I have reviewed, @dhruvpal05 - thanks for your efforts, but you seem to have misunderstood the issue. Please feel free to ask further clarifying questions on my review.

@Wck-iipi
Copy link
Contributor

I would like to work on this issue @rtibbles

@rtibbles
Copy link
Member Author

Hi @Wck-iipi, I assigned you to another issue recently, please finish the fix for that, and then we can revisit this.

@rtibbles
Copy link
Member Author

Ah, apologies, I see you've submitted a PR for that issue already! I'll assign you here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment