Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionalizes the loading action for quiz routes #11822

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

akolson
Copy link
Member

@akolson akolson commented Jan 30, 2024

Summary

This PR conditionalizes the loading action for quiz routes that seems to causes white flashes when navigating around the coach plugin enhanced quiz management.

References

Fixes #11732

Reviewer guidance

Navigate around the enhanced quiz management and ensure that there are no white flashes described in #11732
Also, ensure that no regressions have been introduced by the conditionalization.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@akolson akolson added the TODO: needs review Waiting for review label Jan 30, 2024
@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: small labels Jan 30, 2024
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great thanks Samson. I've tested locally and this will be a good stop-gap measure before the coach routing is reworked altogether.

@nucleogenesis nucleogenesis merged commit 785e939 into learningequality:develop Jan 30, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coach routing: Flash of white on every route navigation in Quiz Creation
2 participants