Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coach routing: Flash of white on every route navigation in Quiz Creation #11732

Closed
2 tasks
nucleogenesis opened this issue Jan 14, 2024 · 1 comment · Fixed by #11822
Closed
2 tasks

Coach routing: Flash of white on every route navigation in Quiz Creation #11732

nucleogenesis opened this issue Jan 14, 2024 · 1 comment · Fixed by #11822
Assignees
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.)

Comments

@nucleogenesis
Copy link
Member

Overview

There are some known issues in Coach (see: #11219 #11422 and issues referenced therein) with the routing handlers. This is resulting in the entire page flashing every time a user changes the route within the new quiz creation application.

This is an undesirable user experience as the process of creating a quiz should feel like a cohesive and immersive process but the screen flashing white when opening the side panel to select/replace content or to edit the current section or to change which section is being edited results in a disjointed UX.

Guidance & notes

This beforeEach call in the coach app.js is almost certainly the cause of the issue.

In order to avoid regressions, it would probably be best to conditionalize the call to set the loading state there to only do so if/when we're not using any of the routes that include these page names. This is similar to the conditionalized dispatch of coachNotifications/stopPolling defined here

Acceptance criteria

  • When the user opens a side panel, changes sections, etc, the screen does not flash.

  • The changes made here do not affect any page except for the quiz creation page (**Note for QA: This means there should be no regressions in Coach Reports or Lessons, but this is not going to resolve or close the issues linked above)

@nucleogenesis nucleogenesis added the APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) label Jan 14, 2024
@akolson
Copy link
Member

akolson commented Jan 29, 2024

I agree with @nucleogenesis about. This is a major culprit.

This beforeEach call in the coach app.js is almost certainly the cause of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants