Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed KResponsiveWindow to useKResponsivewindow in Slidehow Viewer … #11534

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Changed KResponsiveWindow to useKResponsivewindow in Slidehow Viewer … #11534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5fe1d9
Changed KResponsiveWindow to useKResponsivewindow in Slidehow Viewer …
moweiss Nov 15, 2023
0382706
Run linter
MisRob Dec 15, 2023
28b14b3
Fix AUTHORS.md format
MisRob Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,3 +99,4 @@ If you have contributed to Kolibri, feel free to add your name and Github accoun
| Vikramaditya Singh | Ghat0tkach |
| Kris Katkus | katkuskris |
| Garvit Singhal | GarvitSinghal47 |
| Mazen Oweiss | moweiss |
11 changes: 9 additions & 2 deletions kolibri/plugins/slideshow_viewer/assets/src/views/SlideshowRendererComponent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
import client from 'kolibri.client';

import responsiveElementMixin from 'kolibri.coreVue.mixins.responsiveElementMixin';
import responsiveWindowMixin from 'kolibri.coreVue.mixins.responsiveWindowMixin';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';

import UiIconButton from 'kolibri-design-system/lib/keen/UiIconButton';
import CoreFullscreen from 'kolibri.coreVue.components.CoreFullscreen';
Expand All @@ -102,7 +102,14 @@
HooperPagination,
HooperNavigation,
},
mixins: [responsiveElementMixin, responsiveWindowMixin],
mixins: [responsiveElementMixin],
setup() {
const { windowIsLarge, windowIsSmall } = useKResponsiveWindow();
return {
windowIsLarge,
windowIsSmall,
};
},
data: () => ({
isInFullscreen: false,
slides: [],
Expand Down