-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed KResponsiveWindow to useKResponsivewindow in Slidehow Viewer … #11534
Changed KResponsiveWindow to useKResponsivewindow in Slidehow Viewer … #11534
Conversation
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this! The changes are as requested, but the failing test will need to be fixed before this pr can be approved. You can do this by manually running the auto-formatters with yarn run lint-frontend:format
, as mentioned in the Kolibri developer documentation, then updating this pull request with those changes. Additionally, this pr should reference and close issue #11331
rather than #11328
Hi @moweiss, do you need any support with finishing the PR? |
@moweiss @LianaHarris360 I run linter so we can proceed to merge. Also, this is the last sub-issue of #11534 so it will be closed too. Thanks both! |
3bdc090
into
learningequality:release-v0.16.x
Summary
This PR changes the KResponsiveWindow to useKResponsiveWindow in Slideshow Viewer Plugin
…
References
Closes #11331
Closes #11321
Reviewer guidance
...
…
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)