Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed KResponsiveWindow to useKResponsivewindow in Slidehow Viewer … #11534

Merged

Conversation

moweiss
Copy link
Contributor

@moweiss moweiss commented Nov 15, 2023

Summary

This PR changes the KResponsiveWindow to useKResponsiveWindow in Slideshow Viewer Plugin

References

Closes #11331
Closes #11321

Reviewer guidance

...


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@LianaHarris360 LianaHarris360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this! The changes are as requested, but the failing test will need to be fixed before this pr can be approved. You can do this by manually running the auto-formatters with yarn run lint-frontend:format, as mentioned in the Kolibri developer documentation, then updating this pull request with those changes. Additionally, this pr should reference and close issue #11331 rather than #11328

@MisRob
Copy link
Member

MisRob commented Dec 7, 2023

Hi @moweiss, do you need any support with finishing the PR?

@github-actions github-actions bot added DEV: renderers HTML5 apps, videos, exercises, etc. DEV: frontend labels Dec 15, 2023
@MisRob
Copy link
Member

MisRob commented Dec 15, 2023

@moweiss @LianaHarris360 I run linter so we can proceed to merge. Also, this is the last sub-issue of #11534 so it will be closed too. Thanks both!

@LianaHarris360 LianaHarris360 merged commit 3bdc090 into learningequality:release-v0.16.x Dec 15, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend DEV: renderers HTML5 apps, videos, exercises, etc. SIZE: small TODO: needs review Waiting for review
Projects
None yet
3 participants