Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix learning facility setup window's Continue button action #11499

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

KshitijThareja
Copy link
Contributor

Summary

This PR aims to fix the bug in the learning facility form of the setup wizard (the continue button moving to next form even if a user has not filled the facility name).

The changes introduced have been fully tested in the local environment and work without any errors. The updated behavior is as show in the video:

verify.mp4

References

Closes #11486

Reviewer guidance

To test these changes, head over to create_facility/1 page of the setup wizard. Clicking continue will now prompt the user to fill the textbox, if left empty, instead of skipping that particular step.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) SIZE: small labels Nov 4, 2023
@KshitijThareja
Copy link
Contributor Author

Hi @rtibbles. Would you like to suggest any more changes?

@MisRob
Copy link
Member

MisRob commented Nov 10, 2023

Hello @KshitijThareja, thank you for your contribution. We will review it.

Copy link
Member

@jredrejo jredrejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rtibbles rtibbles merged commit 4216fc9 into learningequality:release-v0.16.x Nov 13, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup Wizard - The 'Learning facility name' field can be left empty
4 participants