Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing form validation on facility creation on Setup Wizard #11536

Closed
AlexVelezLl opened this issue Nov 16, 2023 · 2 comments
Closed

Missing form validation on facility creation on Setup Wizard #11536

AlexVelezLl opened this issue Nov 16, 2023 · 2 comments
Labels
APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: frontend good first issue Self-contained, straightforward, low-complexity SIZE: very small

Comments

@AlexVelezLl
Copy link
Member

Observed behavior

The facility creation form doesn't validate the required fields before continuing to the next step.

Compartir.pantalla.-.2023-11-16.11_34_14.mp4

Expected behavior

The form shouldn't continue to the next step if the facility name input is empty.

User-facing consequences

Creating facilities with a empty string as names.

Steps to reproduce

  1. In the setup wizard, select use Kolibri as Group Learning.
  2. Select full device setup.
  3. Create a new learning facility.
  4. Let empty the learning facility name.
  5. Click on continue.

Context

Kolibri version: Last version in develop
Operating system: Windows 10
Browser: Opera GX

@AlexVelezLl AlexVelezLl added APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: frontend good first issue Self-contained, straightforward, low-complexity SIZE: very small labels Nov 16, 2023
@pcenov
Copy link
Member

pcenov commented Nov 17, 2023

Hi @AlexVelezLl this is a known issue that should have been fixed by this PR: #11499

@AlexVelezLl
Copy link
Member Author

Oh thanks @pcenov I hadn't seen it among the open issues, but it makes sense if it had just merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: frontend good first issue Self-contained, straightforward, low-complexity SIZE: very small
Projects
None yet
Development

No branches or pull requests

2 participants