Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Welcome Modal for different browser sessions #11492

Conversation

ozer550
Copy link
Member

@ozer550 ozer550 commented Nov 3, 2023

Summary

  • Fixes the bug with display of Welcome Modal w.r.t multiple browser sessions.
  • Move PostSetup Modal to index level.
  • Use getter function along with localStorage to decide display of Welcome Modal.

References

closes #11456

ScreenShot

image
(welcome modal does not get displayed after clearing the DEVICE_WELCOME_MODAL_DISMISSED key from cookies)

Reviewer guidance

  1. Sign in and go to the Library page and/or Device > Channels - observe the welcome modal.
  2. Import channels
  3. Clear all the browser cookies and sign in again, or sign in using a different browser, Welcome Modal is not displayed now!

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: medium labels Nov 3, 2023
@ozer550 ozer550 marked this pull request as draft November 3, 2023 06:59
@ozer550 ozer550 marked this pull request as ready for review November 14, 2023 18:44
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @ozer550!

Code review looks good, and I have tried the following combinations:

  • no channels and no cookies set
  • channels, but no cookie set
  • cookie set, but no channels
    All check out.

@radinamatic - I'm going to go ahead and approve this for testing in the next beta so as to not pull you away from the syncing troubleshooting that you've been working on, but just flagging here for your awareness for testing there.

@marcellamaki marcellamaki merged commit 4859a9a into learningequality:release-v0.16.x Nov 16, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The 'Welcome to Kolibri' modal is displayed regardless of the fact that I have imported channels
2 participants