Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'Welcome to Kolibri' modal is displayed regardless of the fact that I have imported channels #11456

Closed
pcenov opened this issue Oct 25, 2023 · 5 comments · Fixed by #11492 or #11587
Assignees
Labels
APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) bug Behavior is wrong or broken DEV: frontend P0 - critical Priority: Release blocker or regression

Comments

@pcenov
Copy link
Member

pcenov commented Oct 25, 2023

Observed behavior

This is a follow-up issue to #11449 - since we are not tracking the dismissal in anything other than browser state the 'Welcome to Kolibri!' modal will show on the Library page and on Device > Channels regardless of whether the user has already imported channels or not.

Expected behavior

The 'Welcome to Kolibri!' should only be displayed to actual first time users.

Steps to reproduce the issue

  1. Install the latest build from Fix unwanted welcomeModal display #11449 and setup a full facility.
  2. Sign in and go to the Library page and/or Device > Channels - observe the welcome modal
  3. Import channels
  4. Clear all the browser cookies and sign in again, or sign in using a different browser - observe that the Welcome modal is displayed regardless of the fact that the user has already downloaded channels to the device.

More information

Library:

2023-10-24_10-01-38.mp4

Device > Channels:

2023-10-24_10-08-29

Usage Details

Kolibri 0.16beta6
Ubuntu - Chrome, Firefox

@pcenov
Copy link
Member Author

pcenov commented Oct 25, 2023

@marcellamaki @radinamatic

@radinamatic radinamatic added bug Behavior is wrong or broken P0 - critical Priority: Release blocker or regression APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) DEV: frontend labels Oct 25, 2023
@ozer550
Copy link
Member

ozer550 commented Oct 25, 2023

I can take this one!

@marcellamaki
Copy link
Member

Thank you @ozer550! I'll assign you. Let me and @rtibbles know if we can support or clarify anything

@rtibbles rtibbles added P1 - important Priority: High impact on UX and removed P0 - critical Priority: Release blocker or regression labels Oct 30, 2023
@radinamatic
Copy link
Member

Welcome modal still appears, on LoD devices even, upon each app restart.

And even more, @pcenov discovered that the strings appear in English when the language is switched in the UI. Strings are translated in Crowdin, so there must be some reference mismatch.

UI in Arabic UI in French
welcome-arabic welcome-french

All the DBs and logs from testing on Windows 10.

@radinamatic radinamatic reopened this Nov 27, 2023
@radinamatic radinamatic added P0 - critical Priority: Release blocker or regression and removed P1 - important Priority: High impact on UX labels Nov 27, 2023
@radinamatic
Copy link
Member

Changed to P0, since we cannot have LoDs displaying this message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) bug Behavior is wrong or broken DEV: frontend P0 - critical Priority: Release blocker or regression
Projects
None yet
5 participants