updated KDS reference & testing after changes to useKResponsiveWindow #11315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
thanksameeelian
force-pushed
the
side-panel-opening-after-resize
branch
from
fe15b70 to
9121973
Compare
Build Artifacts
|
thanksameeelian
force-pushed
the
side-panel-opening-after-resize
branch
from
9121973 to
0826964
Compare
github-actions
bot
added
APP: Learn
nucleogenesis
approved these changes
Oct 1, 2023
thanksameeelian
force-pushed
the
side-panel-opening-after-resize
branch
from
0826964 to
1022ed6
Compare
thanksameeelian
changed the title
MisRob
reviewed
Oct 4, 2023
| return mount(LearningActivityBar, { propsData }); | ||
| // stubbing out KCircularLoader, as using the actual component led to errors related to | ||
| // Vue Composition API - stub may not be needed once we upgrade to Vue 2.7 | ||
| return mount(LearningActivityBar, { propsData, stubs: ['KCircularLoader'] }); |
There was a problem hiding this comment.
Thansk @thanksameeelian for cleaning this up, I think that it got broken as result of my recent circular loader updates.
This was referenced Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
this links Kolibri to KDS PR 453 - "useKResponsiveWindow update fixing resizing behavior in Learn > Library" which fixes #11212 and potentially other pages where windowBreakpoint miscalculations were occurring under the hood.
the KDS PR fixes a bug observed during QA review in
Learn>Library- in certain cases, rapidly resizing the browser window would cause the sidepanel to automatically display when the screen was small, behavior we did not expect nor want at that screen size. beneath the surface, the components were receiving conflicting information about the current screen size becauseuseKResponsiveWindowwas not updating in the way we expected.to address those issues, the KDS PR introduces changes to the scope of variables within
useKResponsiveWindowand to the way the composable usesuseKWindowDimensions.References
closes #11212
before
2023-09-08_17-03-37.mp4
after
resizing-successfully.mov
Reviewer guidance
Learn>LibraryTesting checklist
PR process
Reviewer checklist
yarnandpip)