-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Fix textbox being unexpectedly focused after the first page load #11290
Conversation
@MisRob seems that there is a problem with the build? |
@pcenov Ah it got stuck somehow. Thank you, I will let you know when it's resolved. |
d01d7c4
to
eda2a4f
Compare
Build Artifacts
|
@pcenov Builds should be now ready |
Great, thanks @pcenov |
eda2a4f
to
05f446c
Compare
The force push only replaced the fork reference to the latest KDS |
I think tests were passing when I referenced the fork and the failing tests occurred after referencing KDS. Makes me think that this installs another KDS update that we forgot to install and that broke tests. I will investigate. |
Superseded by #11315 |
@radinamatic @pcenov
This links Kolibri to this KDS PR learningequality/kolibri-design-system#449 which fixes #9077 and possibly other pages where focus ring appears around textbox on its own when a page loads.
This was caused by
so it's particularly relevant to pages where we load some data for a text box.
Code changes make sense to me and I haven't noticed any issues when I clicked through it briefly, however it's a significant change in the core logic of the component and I'd like to be more confident we don't introduce unexpected regressions. Historically, any updates around focus rings tend to produce bugs in situations we perhaps didn't think of before.
Could you please test textbox keyboard and mouse navigation and outlines thoroughly? Also, if you find any issues, it'd be helpful to check whether it was present on
develop
before so we can be sure that this change is indeed the real cause. In this case, it will really help with debugging. Thank you.