-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly set admin_imported flag at import and deletion. #11254
Merged
rtibbles
merged 6 commits into
learningequality:release-v0.16.x
from
rtibbles:im_an_admin_import_and_im_okay
Sep 26, 2023
Merged
Properly set admin_imported flag at import and deletion. #11254
rtibbles
merged 6 commits into
learningequality:release-v0.16.x
from
rtibbles:im_an_admin_import_and_im_okay
Sep 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
DEV: backend
Python, databases, networking, filesystem...
SIZE: medium
labels
Sep 15, 2023
rtibbles
changed the title
Im an admin import and im okay
Properly set admin_imported flag at import and deletion.
Sep 15, 2023
Build Artifacts
|
…al requests. As could remove other resources that have not been flagged for removal.
Do previously omitted update to current content schema reflection.
rtibbles
force-pushed
the
im_an_admin_import_and_im_okay
branch
from
September 16, 2023 00:23
10e8651
to
a806b8a
Compare
rtibbles
force-pushed
the
im_an_admin_import_and_im_okay
branch
from
September 17, 2023 01:17
a806b8a
to
eb2da96
Compare
jredrejo
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Made some manual tests that were ok
bjester
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
DEV: backend
Python, databases, networking, filesystem...
SIZE: medium
TODO: needs review
Waiting for review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
force_delete
flag from content request handling deletions, as that could force deletions of admin imported resources to occurFalse
orTrue
(or left as is ifNone
).importchannel
command, but the logic is very straight forward.References
Fixes #11225
Reviewer guidance
This should cover all cases, including loading a full channel database import, after partial imports have happened - the only different will be that admin_imported will be
None
rather thanFalse
- but this is equivalent in how we are using it and should be workable. I think this may not cover where a full channel import has happened previously, then admin_imported is set to False for some nodes, while also being available - but then the channel metadata is upgraded.admin_imported being set to
True
should persist across channel upgrades due to our existing upgrade processes that reannotate after the upgrade has happened.Testing checklist
PR process
Reviewer checklist
yarn
andpip
)