Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically synced content should have admin_imported=False #11225

Closed
bjester opened this issue Sep 12, 2023 · 1 comment · Fixed by #11254
Closed

Automatically synced content should have admin_imported=False #11225

bjester opened this issue Sep 12, 2023 · 1 comment · Fixed by #11254
Assignees
Labels
DEV: backend Python, databases, networking, filesystem... P0 - critical Priority: Release blocker or regression

Comments

@bjester
Copy link
Member

bjester commented Sep 12, 2023

Observed behavior

Blaine forgot to follow up on this-- we need to ensure that metadata for automatically synced content has the admin_imported=False if the metadata doesn't already exist or the files are not available at time of syncing. The flag, when True, prevents resources from being garbage collected and removed the device's disk.

Expected behavior

  1. When metadata is imported for content that will be automatically downloaded, if the metadata didn't already exist, the admin_imported flag should be set to False
  2. If the admin later decides to import the same content, meaning the metadata already exists, the admin_imported flag should be set to True
  3. If the admin 'removes' content that has automated syncing requests, it should set the admin_imported=False

User-facing consequences

File resources are not automatically removed from a device to make room for new content.

@bjester bjester added P0 - critical Priority: Release blocker or regression DEV: backend Python, databases, networking, filesystem... labels Sep 12, 2023
@rtibbles
Copy link
Member

If the admin later decides to import the same content, meaning the metadata already exists, the admin_imported flag should be set to True

I think there are two things that we need to do here - firstly update the admin_imported flag to default to True when the metadata is imported, and then also set it properly for the admin imported flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants