Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain the position of save button on tab switch #11186

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

nikkuAg
Copy link
Contributor

@nikkuAg nikkuAg commented Sep 1, 2023

Summary

After switching tabs to the info page, the device information stored in the store was getting removed. In the function that checks if the device is Android, I have added a condition to reset the device info if it is undefined.

device-settings-google-chrome-2023-09-01-15-59-27_ism7LRXD.mp4

References

#11178

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) SIZE: very small labels Sep 1, 2023
@pcenov pcenov self-requested a review September 1, 2023 14:51
Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radinamatic - I confirm that this issue is fixed now.

@MisRob MisRob requested a review from AllanOXDi September 4, 2023 11:58
Copy link
Member

@AllanOXDi AllanOXDi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AllanOXDi
Copy link
Member

Thanks @nikkuAg for working on this.

@MisRob MisRob merged commit 722ac12 into learningequality:release-v0.16.x Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) SIZE: very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants