Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device > Settings - The 'Save changes' button is changing it's position #11178

Closed
pcenov opened this issue Aug 29, 2023 · 9 comments
Closed

Device > Settings - The 'Save changes' button is changing it's position #11178

pcenov opened this issue Aug 29, 2023 · 9 comments
Assignees
Labels
APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have SIZE: small

Comments

@pcenov
Copy link
Member

pcenov commented Aug 29, 2023

Observed behavior

When I go to Device > Settings for the first time then I see the 'Save changes' button correctly positioned at the bottom right of the screen. However if I navigate specifically to the 'Info' page and then go back to 'Settings' then the button is no longer positioned correctly.

Expected behavior

No changes in the button's position.

Steps to reproduce the issue

  1. Install the latest Beta 4 build.
  2. Go to Device > Settings and observe the position of the button.
  3. Go to Device > Info
  4. Go back to Device > Settings

More information

2023-08-29_17-02-12.mp4

Usage Details

Kolibri 0.16beta4
Windows 10, Ubuntu - Chrome, Firefox

@pcenov
Copy link
Member Author

pcenov commented Aug 29, 2023

@radinamatic

@marcellamaki marcellamaki added P2 - normal Priority: Nice to have APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) help wanted Open source contributors welcome good first issue Self-contained, straightforward, low-complexity SIZE: small labels Aug 29, 2023
@nikkuAg
Copy link
Contributor

nikkuAg commented Aug 31, 2023

Is this issue still open? I would like to work on this.

@MisRob
Copy link
Member

MisRob commented Aug 31, 2023

Hi @nikkuAg, yes it is and you're welcome to tackle this one

@nikkuAg
Copy link
Contributor

nikkuAg commented Sep 1, 2023

@MisRob, I have opened a PR, please review it

@MisRob
Copy link
Member

MisRob commented Sep 4, 2023

Thank you, @nikkuAg, we will have a look

@V0YD23
Copy link
Contributor

V0YD23 commented Sep 22, 2023

@MisRob is this issue still open , if yes then can you assign it to me?

@MisRob
Copy link
Member

MisRob commented Sep 22, 2023

Hello @yash1378. this has already been fixed by @nikkuAg in #11186

@MisRob MisRob closed this as completed Sep 22, 2023
@V0YD23
Copy link
Contributor

V0YD23 commented Sep 22, 2023

@MisRob can you please suggest me some beginner friendly issues as i am totally a newcomer?

@MisRob
Copy link
Member

MisRob commented Sep 22, 2023

Hi @yash1378, thank you for your interest. I just opened an issue here #11287 that should be very simple so I'd recommend that as the first one. Just a note that you need to do your setup on release-v0.16.x branch rather than develop for that work. Please send us a comment on that issue, otherwise I won't be able to assign you.

If you haven't seen it already, I recommend checking out the contributing guidelines https://github.com/learningequality/kolibri/blob/release-v0.16.x/CONTRIBUTING.md.

We'll probably have some more issues here in Kolibri or perhaps in Studio (other product we welcome contributions for) next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have SIZE: small
Projects
None yet
Development

No branches or pull requests

6 participants