Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate KEmptyPlaceholder to use KOptionalText #10050

Merged
merged 7 commits into from
Feb 28, 2023

Conversation

AlexVelezLl
Copy link
Member

Summary

Migrate KEmptyPlaceholder to use KOptionalText, a new component introduced in the PR: learningequality/kolibri-design-system#403

Reviewer guidance

Link the KDS dependency with the branch of the requested PR. Then, go to any of the sections where KEmptyPlaceholder is used, and KOptionalText should replay.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@AlexVelezLl AlexVelezLl added the TODO: needs review Waiting for review label Jan 29, 2023
@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) SIZE: small labels Jan 29, 2023
kolibri/core/package.json Outdated Show resolved Hide resolved
@AlexVelezLl AlexVelezLl requested a review from rtibbles February 16, 2023 01:06
yarn.lock Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

@rtibbles rtibbles merged commit bc45bfa into learningequality:develop Feb 28, 2023
@AlexVelezLl AlexVelezLl deleted the migrate-koptionaltext branch February 28, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) SIZE: medium SIZE: small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants