Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change KEmptyPlaceholder to KOptionalText #285

Closed
indirectlylit opened this issue Dec 14, 2021 · 1 comment
Closed

change KEmptyPlaceholder to KOptionalText #285

indirectlylit opened this issue Dec 14, 2021 · 1 comment
Assignees
@AlexVelezLl
Labels
category: library Shared code library Component: KEmptyPlaceholder type: proposal New feature or request

Comments

@indirectlylit
Copy link
Contributor

Product

Kolibri

Desired behavior

KEmptyPlaceholder is always used with a v-else directive next to another text block.

We should have a KOptionalText component will either display the text or the existing KEmptyPlacehlder if it's an empty string, undefined, or null.

(Optional) The Value Add

Simplify product code
@indirectlylit indirectlylit added type: proposal New feature or request category: library Shared code library labels Dec 14, 2021
@indirectlylit indirectlylit mentioned this issue Dec 14, 2021
Closed
9 tasks
@AlexVelezLl AlexVelezLl self-assigned this Dec 14, 2022
@AlexVelezLl AlexVelezLl mentioned this issue Dec 17, 2022
Merged
7 tasks
@rtibbles
Copy link
Member

This has been addressed by #403 and updated in Kolibri in learningequality/kolibri#10050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexVelezLl AlexVelezLl

Labels
category: library Shared code library Component: KEmptyPlaceholder type: proposal New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rtibbles @indirectlylit @MisRob @AlexVelezLl