Prevent display of welcome modal in LOD's

[ozer550]

Summary

Use the existing getter function "isLearnerOnlyImport" to prevent display of welcome modal in the LOD's

…

References

closes #11456

…

Reviewer guidance

• Open the library section.
• The Welcome Modal does not appear any more.

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.0b9.dev0_git.36.ge5fce4ea.pex
Windows Installer (EXE)	kolibri-0.16.0b9.dev0+git.36.ge5fce4ea-unsigned.exe
Debian Package	kolibri_0.16.0b9.dev0+git.36.ge5fce4ea-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.0b9.dev0+git.36.ge5fce4ea-0.3.0.dmg
Android Package (APK)	kolibri-0.16.0b9.dev0+git.36.ge5fce4ea-0.1.0-debug.apk
TAR file	kolibri-0.16.0b9.dev0+git.36.ge5fce4ea.tar.gz
WHL file	kolibri-0.16.0b9.dev0+git.36.ge5fce4ea-py2.py3-none-any.whl

[pcenov]

Hi @ozer550 I can confirm that the welcome modal is no longer being displayed for a LOD device. What I find strange is that while regression testing I noticed that the issue whit the reappearing modal which was fixed in #11492 is now observed in this build - have you rebased to the latest version of Kolibri?

[ozer550]

Hi @pcenov! The build does seem to have required code to fix the issue that you mentioned as regression. I checked both local branch and downloading the pex file. It seems to be working correctly for me.

[rtibbles]

Fixes the issue at hand.

[rtibbles]

This is fine - in future, we'll try to move more towards using the core useUser composable that wraps this, so we can deprecate and remove the core vuex state.

[pcenov]

Hi @ozer550 after additional investigation on my end, the issue with the Welcome modal being constantly displayed is still valid in LODs and in normal devices if there aren't any downloaded channels yet. Will open a separate issue for that.

2023-12-14_17-20-41.mp4

[ozer550]

Hi @pcenov, If I understand correctly here, we do not want the WelcomeModal to be displayed once again when the user deletes all the channels, it should be just displayed once at the very start when there are no channels and the user has never seen the welcome Modal before? cc @radinamatic

[radinamatic]

@ozer550

Yes, the welcome modal should not be displayed to users who have seen it already, back when they installed Kolibri for the first time, even when they (for any reason at some point) delete all the channels they have on the device.

This condition should be implemented together with not displaying the welcome modal to LoDs altogether, since the wording of the string is clearly directed to admins, and not learner users. To sum it up:

1. Completely disable the welcome modal for LoDs.
2. Do not use the presence of channels as the condition for displaying the welcome modal (therefore those users who at some point delete all their channels do not need to see the welcome modal again).

[rtibbles]

I am not sure why we would remove the no channel condition. If anything this will make it more likely for a user to see the modal again (it would happen every time they clear the site data, rather than if they cleared the site data and had no channels).