-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure visibility of focus-ring in Firefox #827
Ensure visibility of focus-ring in Firefox #827
Conversation
@MisRob ,please help me here, I don't know whats wrong with my linter, it always fails here , in my local server it shows "done in secs." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RONAK-AI647! I confirm this works well in both Firefox and Chrome, and the change from focus
to focus-visible
have further benefits. Just one cleanup note.
Regarding the linting trouble, I am fine to lint and push before we merge, however, would you mind doing a recording of what you are experiencing so I can understand better? Perhaps we need to fix something.
On my end, it seems to work, this is what I see:
When i run the yarn lint-fix command in my terminal ,this is the output Screen.Recording.2024-11-16.073500.mp4Here I thought I might have the browser update issue , but that warning shows in your terminal as well @MisRob . |
That's interesting, @RONAK-AI647. I don't know what's the cause. Would you like to open an issue so we can start tracking it? I noticed some other contributors facing similar troubles. I'd be grateful if you could include recording or description of the following (1) Do some change that a linter should fix (e.g. remove It'd be great if you could be as specific as possible and include what change should be fixed and wasn't. Also information about your OS and |
Regarding this PR, I will do the fix and then merge. Thanks a lot :)! |
Description
Making sure the documentation focus-ring is visible in Firefox(earlier it was only visible in chrome).
Issue addressed #206
Addresses #PR# HERE#827
Before/after screenshots
Screen.Recording.2024-11-14.225136.-.Copy.mp4
Changelog
Steps to test
(optional) Implementation notes
At a high level, how did you implement this?
Does this introduce any tech-debt items?
Testing checklist
Reviewer guidance
Comments
I think now its visible in both browsers clearly,