Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation focus ring is nearly invisible in Firefox #206

Closed
indirectlylit opened this issue Mar 25, 2021 · 10 comments
Closed

Documentation focus ring is nearly invisible in Firefox #206

indirectlylit opened this issue Mar 25, 2021 · 10 comments
Assignees
Labels
category: supporting code Implementation of the system good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P3 - low Priority: Stretch goal

Comments

@indirectlylit
Copy link
Contributor

Product

Design system docs

Expected behavior

Focus ring should be easily visible in all browsers

Actual behavior

Visible in Chrome but not Firefox on macOS:

Chrome Firefox
2021-03-25 09 10 09 2021-03-25 09 10 25
@indirectlylit indirectlylit added the category: supporting code Implementation of the system label Mar 25, 2021
@indirectlylit indirectlylit added the P3 - low Priority: Stretch goal label Nov 30, 2021
@MisRob MisRob added good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome and removed tag: beginner friendly labels Aug 18, 2023
@nikkuAg
Copy link

nikkuAg commented Nov 30, 2023

Is this issue still open? I would like to work on this

@MisRob
Copy link
Member

MisRob commented Dec 7, 2023

Hi @nikkuAg, yes that'd be a nice improvement. I'm assigning you.

@MisRob
Copy link
Member

MisRob commented Feb 15, 2024

Hi @nikkuAg, since we haven't seen activity here for a long time, I will assign you, If you're still interested, you're welcome to messages us and we can assign again. Be well

@RONAK-AI647
Copy link
Contributor

Hi @indirectlylit @AlexVelezLl I want an opportunity to work on it , will you please assign it to me ,thank you.

@AlexVelezLl
Copy link
Member

Hey @RONAK-AI647! For sure! I am assigning this to you. Let us know if you have any question :)

@RONAK-AI647
Copy link
Contributor

Hey team members @AlexVelezLl @rtibbles @indirectlylit ,there are some queries in my head ,would be pleased if I get suggestions.

1)I don't see any focus ring in my system when hover around the documentation.

20241031-0524-29.2167171.mp4

2) If the first one is my system error ,then increasing the width of the focus ring is sufficient???
3) Are you sure this is not individual's browser issue? In my case both the browsers gives the same result.

@AllanOXDi
Copy link
Member

AllanOXDi commented Oct 31, 2024

Hi @RONAK-AI647

   > 1)I don't see any focus ring in my system when hover around the documentation.

Could you try navigating using a tab key?

@RONAK-AI647
Copy link
Contributor

@indirectlylit @MisRob kindly take a look at my PR .

@MisRob
Copy link
Member

MisRob commented Nov 15, 2024

Thanks @RONAK-AI647!

@MisRob
Copy link
Member

MisRob commented Nov 18, 2024

Closed by #827

@MisRob MisRob closed this as completed Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: supporting code Implementation of the system good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P3 - low Priority: Stretch goal
Projects
None yet
Development

No branches or pull requests

6 participants