Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce visual testing mechanism to KDS #742

Open
wants to merge 68 commits into
base: nodejs-upgrade
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
9abf33e
Setup initial configuration
KshitijThareja Jun 19, 2024
9b01670
Add and configure percy for visual tests
KshitijThareja Jun 21, 2024
f01b65d
Change server configuration and file names for visual tests
KshitijThareja Jun 29, 2024
a538bf2
Add component rendering mechanism for visual testing
KshitijThareja Jun 30, 2024
1ffca8e
Remove unused packages
KshitijThareja Jun 30, 2024
d9e1d14
Add JSDoc for testing playground and modify server script
KshitijThareja Jul 2, 2024
519dd63
Update KImg unit tests and eslint configuration
KshitijThareja Jul 6, 2024
64301f8
Use concurrently to manage startup and termination of tests
KshitijThareja Jul 9, 2024
759ef28
Update waitForServer function to use http
KshitijThareja Jul 10, 2024
1bc6ea1
Remove unused dependencies and separate visual tests from yarn test
KshitijThareja Jul 10, 2024
2b06d96
Separate visual tests from yarn test command
KshitijThareja Jul 10, 2024
905e770
Merge pull request #670 from KshitijThareja/visual-testing
bjester Jul 10, 2024
65a08d4
Introduce abstraction for component rendering functions and support f…
KshitijThareja Jul 11, 2024
d2ea3d1
Initial workflow config
KshitijThareja Jul 14, 2024
8ce5fe8
Fix the initial workflow for visual tests job
KshitijThareja Jul 16, 2024
fde157f
Merge branch 'gsoc/visual-testing' into vt-add-concurrently
KshitijThareja Jul 16, 2024
3ef3ee1
Merge pull request #677 from KshitijThareja/vt-add-concurrently
bjester Jul 16, 2024
2eaabdb
Add automatic comments job for visual testing workflow
KshitijThareja Jul 17, 2024
310f75b
Fix lint errors
KshitijThareja Jul 17, 2024
f6c66f3
Abstraction for page navigation
KshitijThareja Jul 17, 2024
1eba82f
Fix lint errors
KshitijThareja Jul 17, 2024
c37ddd3
Merge branch 'gsoc/visual-testing' into vt-abstraction
KshitijThareja Jul 17, 2024
f4373a0
Introduce visual testing to the existing Javascript tests workflow
KshitijThareja Jul 17, 2024
bdea16d
Introduce visual testing to the existing Javascript tests workflow
KshitijThareja Jul 17, 2024
eb95513
Introduce visual testing to the existing Javascript tests workflow
KshitijThareja Jul 17, 2024
c0e977f
Replace usage of custom describe blocks with test regex patterns
KshitijThareja Jul 20, 2024
95228a2
Merge branch 'vt-abstraction' of github.com:KshitijThareja/kolibri-de…
KshitijThareja Jul 20, 2024
61c98f9
Remove unintentional changes
KshitijThareja Jul 20, 2024
fde97db
Add comments for rendering function and make variable names clear
KshitijThareja Jul 23, 2024
ad6c1d5
Remove run server step
KshitijThareja Jul 23, 2024
c18b8d5
Remove pipes where not required
KshitijThareja Jul 24, 2024
93f2b7c
Add special test blocks for visual tests to append Visual tag automat…
KshitijThareja Jul 26, 2024
9e45f45
Merge pull request #685 from KshitijThareja/vt-abstraction
AlexVelezLl Jul 26, 2024
c6a3ab3
Add support for default slots rendering
KshitijThareja Jul 31, 2024
19654cf
Change workflow to run on separate environment
KshitijThareja Aug 6, 2024
0821b88
Merge branch 'gsoc/visual-testing' into vt-ghaction
KshitijThareja Aug 6, 2024
dacba7c
Merge pull request #686 from KshitijThareja/vt-ghaction
AlexVelezLl Aug 6, 2024
fe94675
Add option to specify custom dimensions for snapshots
KshitijThareja Aug 6, 2024
d921297
Add puppeteer config for CI environments
KshitijThareja Aug 6, 2024
2e713bc
Remove .puppeteerrc.cjs
KshitijThareja Aug 7, 2024
61d3645
Merge pull request #712 from KshitijThareja/vt-ghaction
AlexVelezLl Aug 7, 2024
97dbb74
Checkout pr head
AlexVelezLl Aug 7, 2024
bf8a172
Update should skip to include style changes
AlexVelezLl Aug 7, 2024
9b4861d
Initial documentation for visual tests
KshitijThareja Aug 9, 2024
10a1d40
Update comment job to use github-script action
KshitijThareja Aug 9, 2024
6dc4cab
Update visual testing docs with links to mentioned files
KshitijThareja Aug 9, 2024
981aab9
Update documentation
KshitijThareja Aug 13, 2024
0ff28b9
Updat comment job to use utils file
KshitijThareja Aug 13, 2024
d536c84
Migrate findComment and generateComment functions to githubUtils.js
KshitijThareja Aug 13, 2024
cdbf6ca
Add reference to documentation in getting-started doc
KshitijThareja Aug 13, 2024
1a28076
Merge pull request #720 from KshitijThareja/vt-ghaction
AlexVelezLl Aug 14, 2024
05809de
Update jsdoc
AlexVelezLl Aug 14, 2024
855a5a2
Merge branch 'gsoc/visual-testing' into vt-test
AlexVelezLl Aug 14, 2024
d1ead28
Merge branch 'gsoc/visual-testing' into vt-test
AlexVelezLl Aug 14, 2024
798dd24
Modify testing playground to render named and default slots in a sing…
KshitijThareja Aug 15, 2024
b84eafa
Add jsdocs for renderComponent and takeSnapshot functions
KshitijThareja Aug 15, 2024
384e593
Fix lint error
KshitijThareja Aug 15, 2024
9471e37
Remove async from describe block
KshitijThareja Aug 15, 2024
6f3ab99
Merge branch 'vt-test' of https://github.com/KshitijThareja/kolibri-d…
KshitijThareja Aug 15, 2024
625cff0
Add snapshot options specifying test widths
KshitijThareja Aug 16, 2024
3bddaab
Merge pull request #710 from KshitijThareja/vt-test
AlexVelezLl Aug 16, 2024
5c079b5
Update test command to work for all test files
KshitijThareja Aug 18, 2024
80cceae
Merge branch 'gsoc/visual-testing' into vt-doc
KshitijThareja Aug 20, 2024
176a971
Add additional info for rendering complex components
KshitijThareja Aug 20, 2024
6e06337
Add link to percy documentation
KshitijThareja Aug 21, 2024
33435a3
Update info for usage of test blocks for visual tests
KshitijThareja Aug 21, 2024
28e3c40
Update required node version specification
KshitijThareja Aug 22, 2024
ac305aa
Merge pull request #721 from KshitijThareja/vt-doc
AlexVelezLl Aug 23, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove .puppeteerrc.cjs
KshitijThareja committed Aug 7, 2024
commit 2e713bccf1a3f395bf43a7d8cfb155d3bb7991ca
2 changes: 0 additions & 2 deletions .github/workflows/visual_tests.yml
Original file line number Diff line number Diff line change
@@ -24,8 +24,6 @@ jobs:
environment: percy_tests
outputs:
percy_url: ${{ steps.extract-url.outputs.percy_url }}
env:
CI: true
steps:
- uses: actions/checkout@v4
- name: Use Node.js
8 changes: 0 additions & 8 deletions .puppeteerrc.cjs

This file was deleted.