Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add puppeteer config for CI environments for running visual tests workflow #712

Merged

Conversation

KshitijThareja
Copy link
Contributor

Description

Add puppeteer config to set cache location and modify visual test workflow to install chrome before running tests.

Changelog

  • [#PR no]
    • Description: -
    • Products impact: -
    • Addresses: -
    • Components: -
    • Breaking: -
    • Impacts a11y: -
    • Guidance: -

[#PR no]: PR link

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

After review

  • The changelog item has been pasted to the CHANGELOG.md

Comments

Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that with this is working!! But I have removed the .puppeteerrc file and it still works without it, so it seems that is not needed. Is there an special reason to add this file?

@KshitijThareja
Copy link
Contributor Author

Hey. Happy to hear that it works!
While going through some old GitHub issues in the Puppeteer repository, I read that adding a .puppeteer.rc file could help locate the cache directory in CI environments. As the error logs stated both the possibilities (either the browser is not installed or the path to cache directory is incorrectly configured), I decided to include both the changes.

I'll remove the file if things work fine without it :)

@AlexVelezLl AlexVelezLl merged commit 61d3645 into learningequality:gsoc/visual-testing Aug 7, 2024
4 of 10 checks passed
@KshitijThareja KshitijThareja deleted the vt-ghaction branch August 9, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants