-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Internet Explorer 11 specific logic from KTextTruncator #652
Conversation
Thank you for following up. I think some more cleanup is needed, since
condition is not needed anymore. Can you simplify the
? |
lib/KTextTruncator.vue
Outdated
} | ||
// Default return value for when neither condition is met | ||
return {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't be needed, see #652 (comment)
CHANGELOG.md
Outdated
- **Components:** KTextTruncator | ||
- **Breaking:** no | ||
- **Impacts a11y:** - | ||
- **Guidance:** Consumers need to ensure the modal is still working correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these changes have anything to do with the modal, possibly result of copy-paste? Please cleanup.
Thank you for your guidance,can you check a latest commit @MisRob |
Thank you @Nivas7, all is looking good to me now. One last thing before merge - please run |
Thanks for ur support |
Apologize for late i fixed linting errors. @MisRob thinks the code should works fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Nivas7, no problem! All is looking good to me (just pushing a small update of changelog). Thanks and congratulations to your first contribution.
Description
In summary, to remove IE11 support from the KTextTruncator component:
Remove the lineHeightIE prop.
Remove the IE11 fallback logic and related styles from the truncate method.
This change, treated as a breaking change, aims to simplify the component by removing unnecessary code for the unsupported IE11 browser. The updated component should be thoroughly tested to ensure no regressions.
Issue addressed
#643
Addresses #652
Before/after screenshots
Before
After
Testing checklist
Reviewer guidance
After review
CHANGELOG.md
Comments