Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Internet Explorer 11 specific logic from KTextTruncator #643

Closed
1 task
MisRob opened this issue May 19, 2024 · 3 comments
Closed
1 task

Remove Internet Explorer 11 specific logic from KTextTruncator #643

MisRob opened this issue May 19, 2024 · 3 comments
Assignees
Labels
Component: KTextTruncator good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have

Comments

@MisRob
Copy link
Member

MisRob commented May 19, 2024

🌱 Are you new to the codebase? Welcome and please see the contributing guidelines.

Description

Remove logic specific to Internet Explorer 11 from KTextTruncator, including:

Impact

Starting with Kolibri 0.17, we're dropping IE11 support. Therefore, KDS no longer needs to account for IE11-specific cases. This update removes unnecessary code, making future maintenance easier.

Trade-offs

None identified.

Guidance

Target the develop branch, as this will be released as a breaking change.

Acceptance criteria

@MisRob MisRob added good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome Component: KTextTruncator labels May 19, 2024
@MisRob MisRob added the P2 - normal Priority: Nice to have label May 27, 2024
@Nivas7
Copy link
Contributor

Nivas7 commented Jun 5, 2024

Can you please Assign me on this issue?

@MisRob
Copy link
Member Author

MisRob commented Jun 5, 2024

Hi @Nivas7, yes, thanks for volunteering!

@MisRob
Copy link
Member Author

MisRob commented Jun 18, 2024

Closed by #652

@MisRob MisRob closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: KTextTruncator good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have
Projects
None yet
Development

No branches or pull requests

2 participants