-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Internet Explorer 11 specific logic from KTextTruncator #651
Conversation
I hope this Problem Will be solved? |
@@ -1,19 +1,4 @@ | |||
<template> | |||
|
|||
<!-- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine to cleanup comments that are specific to IE11, but please make sure to read them carefully and do not remove comments that have nothing to do with IE11 logic. This applies to all other removed comments in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's Good Catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Nivas7, thanks! Please see my note about comments. Resolving it should also help with missing "Props" descriptions for text
and maxLines
(can be seen in the "After" screenshots)
Also please run linter |
I will make that changes quickly:) |
apologize for the mistake i re fork my repo and made my pr |
How can i made pull req to develop barnch from fork it has only releases channellog.md not develop branch challange.md |
I solved the linting error and removed the Internet explorer props and fallback function i got so much confusion in pushing this to develop Branch , I Apologized for this |
Hi @Nivas7, no problem. I'd recommend you pull the latest develop from upstream to your local, start a new branch from it, and then open a new pull request. It may be helpful to spend a while looking into some tutorials on git. If you don't see the |
Remove Internet Explorer 11 specific logic from KTextTruncator - #643
Description
In summary, to remove IE11 support from the KTextTruncator component:
Remove the lineHeightIE prop.
Remove the IE11 fallback logic and related styles from the truncate method.
This change, treated as a breaking change, aims to simplify the component by removing unnecessary code for the unsupported IE11 browser. The updated component should be thoroughly tested to ensure no regressions.
Addresses #PR# HERE
Before/after screenshots
Before
After
Changelog
Testing checklist
Reviewer guidance
After review
CHANGELOG.md