-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KTextbox: Support a "clearable" prop to show a clear button #591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! @practicatto! Thanks for your work here, this is looking great! But there are some little things we can improve =)
Also, a check is failing because we need to update the Changelog file with a new entry that is the same as the one you put in the PR descripciton. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THanks! @practicatto Just one last thing and we are ready to go!
add tests and fix clear button remove unnecessary styles and add kiconbutton instead of button fix tests with component fix linter fix borders add requested changes add aria label add link in changelog pr591 add docs fix lint fix lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work @practicatto! Code makes sense and everything seems to be working ok. Thank you!
Thank you for your guidance!! :) |
Description
KTextbox support to show clearable button when clearable prop to true
Issue addressed
Addresses #584
Before/after screenshots
Changelog
Testing checklist
Reviewer guidance
After review
CHANGELOG.md