Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KTextbox: Support a "clearable" prop to show a clear button #589

Closed

Conversation

practicatto
Copy link
Contributor

@practicatto practicatto commented Mar 25, 2024

Description

KTextbox support to show clearable button when clearable prop to true

Issue addressed

Addresses #584

Before/after screenshots

Steps to test

  1. Run the web server with yarn dev
  2. Add KTextbox to the playground.vue file
  3. Play with it :)

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

After review

  • The changelog item has been pasted to the CHANGELOG.md

Comments

@MisRob MisRob self-requested a review March 26, 2024 07:26
@MisRob MisRob self-assigned this Mar 26, 2024
@practicatto
Copy link
Contributor Author

practicatto commented Mar 26, 2024

@MisRob Hi! I've closed the previous pull request as it was mistakenly based on the release-v4 branch. My apologies for any inconvenience this may have caused. I've submitted a new pull request after addressing a few minor issues I initially overlooked. As I'm still familiarizing myself with the developer's guide, I would greatly appreciate any feedback you could provide to help me improve. This is the new PR i opened today #591

@MisRob
Copy link
Member

MisRob commented Mar 29, 2024

Hi @practicatto, thank you! I think it's fine to target the release-v4 here. I will be glad to have a look at your PR, just note that right now I have quite a full PR queue so it may take me some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants