Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed _dev-only to dev-only #478

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Conversation

BabyElias
Copy link
Contributor

@BabyElias BabyElias commented Oct 24, 2023

Description

Changed command name from _dev-only to dev-only for easiness.

Issue addressed

Fixes #474

@akolson akolson requested review from akolson and MisRob October 24, 2023 15:18
package.json Show resolved Hide resolved
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BabyElias. Great job! I have left a comment for you to address.

Also, please be sure to update the CHANGLOG.md file with required information as stipulated in the guidelines. This same information(changelog) is also relevant for your PR description(See the template here)

Please be sure to let us know incase you have an questions or issues to clarify. Thanks

@BabyElias
Copy link
Contributor Author

Done with the required changes :)

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look correct to me. Thanks @BabyElias for your contribution in making the Kolibri ecosystem better. cc @MisRob @thanksameeelian

CHANGELOG.md Show resolved Hide resolved
@MisRob
Copy link
Member

MisRob commented Oct 26, 2023

Congratulation to your first contribution, @BabyElias!

@BabyElias
Copy link
Contributor Author

Any more changes that are needed?

@akolson
Copy link
Member

akolson commented Oct 26, 2023

Hi @BabyElias! I don't think so. We should be good to go now and this should be merged soon. Thanks

@akolson akolson merged commit 2fc5ee8 into learningequality:main Oct 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The yarn dev-only misspelled in 01_getting_started.md
3 participants