Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The yarn dev-only misspelled in 01_getting_started.md #474

Closed
muditchoudhary opened this issue Oct 20, 2023 · 3 comments · Fixed by #478
Closed

The yarn dev-only misspelled in 01_getting_started.md #474

muditchoudhary opened this issue Oct 20, 2023 · 3 comments · Fixed by #478
Assignees
@BabyElias

Comments

@muditchoudhary
Copy link
Contributor

Product

In the Design System getting started docs 01_getting_started.md the command yarn dev-only is misspelled. It should be yarn _dev-only

Additional information

In the docs
image
In the package.json
image
@MisRob
Copy link
Member

MisRob commented Oct 23, 2023

Thanks for reporting @muditchoudhary!

Perhaps it'd be best to rename the command in package.json from _dev-only to dev-only as it's simpler to type.

@MisRob MisRob changed the title [Title]: The yarn dev-only misspelled in 01_getting_started.md The yarn dev-only misspelled in 01_getting_started.md Oct 23, 2023
@BabyElias
Copy link
Contributor

Hello @MisRob !
Can I work on this issue?

@akolson
Copy link
Member

akolson commented Oct 24, 2023

Hello @BabyElias. Yes, you can. Thanks.
Please be sure to let us know in case you need any support along the way.

@BabyElias BabyElias mentioned this issue Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BabyElias BabyElias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed _dev-only to dev-only BabyElias/kolibri-design-system
4 participants
@akolson @MisRob @muditchoudhary @BabyElias